Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

Wed Dec 30 17:05:05 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/
-----------------------------------------------------------

(Updated Dec. 30, 2015, 5:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, KDE Usability and Martin Klapetek.

Changes
-------

Submitted with commit be4b0f5aacb9f6550d4e4d0f7226c9e78acd63b5 by Kai Uwe Broulik to branch master.

Repository: plasma-workspace

Description
-------

It's nice that we offer to configure notifications from a notification. Usually, however, you're lost in a dialog notifications and you have no idea which event you actually just saw.

Diffs
-----

  applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
  applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
  applets/notifications/package/contents/ui/Notifications.qml f479a65 
  dataengines/notifications/notificationaction.cpp da5ba14 
  dataengines/notifications/notifications.operations d2a120a 
  dataengines/notifications/notificationsengine.h b275830 
  dataengines/notifications/notificationsengine.cpp 829ef4e 

Diff: https://git.reviewboard.kde.org/r/126570/diff/

Testing
-------

I now get the actual notification highlighted when I press the configure button of one. Neat.

File Attachments
----------------

Highlighted notification
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151230/407a71f1/attachment.html>