Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

[Martin Klapetek]

> On Dec. 30, 2015, 12:49 p.m., David Edmundson wrote:
> > Ship It!

This requires frameworks 5.18 (because of the KNotifyConfig changes),
so it should bump the required frameworks version, otherwise build
failures will happen.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/#review90333
-----------------------------------------------------------


On Dec. 29, 2015, 11:55 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126570/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 11:55 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> It's nice that we offer to configure notifications from a notification. Usually, however, you're lost in a dialog notifications and you have no idea which event you actually just saw.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
>   applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
>   applets/notifications/package/contents/ui/Notifications.qml f479a65 
>   dataengines/notifications/notificationaction.cpp da5ba14 
>   dataengines/notifications/notifications.operations d2a120a 
>   dataengines/notifications/notificationsengine.h b275830 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126570/diff/
> 
> 
> Testing
> -------
> 
> I now get the actual notification highlighted when I press the configure button of one. Neat.
> 
> 
> File Attachments
> ----------------
> 
> Highlighted notification
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151230/4ab5cf1c/attachment.html>