Review Request 126576: Don't emit signals in another object from panel.
David Edmundson
david at davidedmundson.co.uk
Wed Dec 30 16:07:37 UTC 2015
On Dec. 30, 2015, 12:52 p.m., David Edmundson wrote:
> > The rest LGTM. Thanks.
You're right it's unrelated.
Removed for now.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/#review90338
-----------------------------------------------------------
On Dec. 30, 2015, noon, David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126576/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, noon)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Emitting objects in another object is generally bad practice.
>
> ShellCorona::availableScreenRect knows what properties of panelview we
> use, so tracking of property changes should be in ShellCorona.
>
>
> Diffs
> -----
>
> shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7
> shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd
>
> Diff: https://git.reviewboard.kde.org/r/126576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151230/30b15916/attachment.html>
More information about the Plasma-devel
mailing list