Review Request 126576: Don't emit signals in another object from panel.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/#review90343
-----------------------------------------------------------

Ship it!


looks good, i'm also not 100% convinced by the removal of that line even tough i agree with it, do a test  show no regressions?


shell/panelview.cpp 
<https://git.reviewboard.kde.org/r/126576/#comment61814>

    was probably a workaround to setscreen not working? looks unrelated indeed, but if now works fine without this line it should be committed as well


- Marco Martin


On Dec. 30, 2015, noon, David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126576/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Emitting objects in another object is generally bad practice.
> 
> ShellCorona::availableScreenRect knows what properties of panelview we
> use, so tracking of property changes should be in ShellCorona.
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
>   shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/126576/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151230/4f6cf31e/attachment-0001.html>