Review Request 126538: Don't duplicate a tonne of KCrash code
David Edmundson
david at davidedmundson.co.uk
Mon Dec 28 11:37:22 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 11:37 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 3ff5cdd3cf75c7d9d7edd72d88dd1c440fb1995d by David Edmundson to branch master.
Repository: plasma-workspace
Description
-------
KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.
Timeouts are sligthly different, but if changes are genuinely needed we can add options to KCrash.
Diffs
-----
shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3
shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2
shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0
Diff: https://git.reviewboard.kde.org/r/126538/diff/
Testing
-------
Ran with -w
killed -s SIGSEGV
windowed version restarted
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/73b4ceb4/attachment-0001.html>
More information about the Plasma-devel
mailing list