Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/
-----------------------------------------------------------

(Updated Dez. 28, 2015, 12:17 vorm.)


Review request for Plasma.


Changes
-------

Rebased to master

The OSD issue I mentioned is nowhere to be seen


Summary (updated)
-----------------

Don't animate from previous pixmap when IconItem has been invisible


Repository: plasma-framework


Description
-------

We have a lot of reusable singletons that are just hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the previous state, even if the previous action happened minutes ago.

This patch makes it track its visibility and skip the fade-and-wait dance when it just became visible. It also removes a visible false call in the tooltip which I didn't know what it was for. (With it in place, the IconItem always becomes visible when moving between tooltip areas, breaking the animation altogether).

@Eike: Could you check whether this makes it more viable for Kicker?


Diffs (updated)
-----

  src/declarativeimports/core/iconitem.h 528f57c 
  src/declarativeimports/core/iconitem.cpp 1e8260e 
  src/declarativeimports/core/tooltip.cpp a5e223b 

Diff: https://git.reviewboard.kde.org/r/122859/diff/


Testing (updated)
-------

Moving between tray icons - icon fades, moving reaaaally rapidly causes it not to load any icon until you halt (dunno if that happened before but doesn't seem too bad)
Hovering tray icon, leaving, waiting, hovering another one - icon does not fade, is there right away
Notifications also don't fade from the previously issued notification icon


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/95b5e687/attachment.html>