Review Request 126460: Honor SkipGrouping hint from KNotification

[David Edmundson]

> On Dec. 21, 2015, 8:38 p.m., David Edmundson wrote:
> > This does seem like a much better way to handle the grouping, so I'll +1 this.
> > 
> > But as for the actual bug that brought you here:
> > Why are we getting two notifications for everything from Plasma in the first place?
> 
> Martin Klapetek wrote:
>     Those are I think two slightly different issues.
>     
>     The lock-widgets one is I think because of multiscreen, cause
>     then you have two containments emitting two same notifications.
>     
>     The other one, which you marked that^ as duplicate of, is likely
>     a combo of bug 346622 and possibly also a multiscreen thing.

Ah, yes - it's the containment emitting it not the shell corona. Makes sense that we emit two.

Thanks


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126460/#review89855
-----------------------------------------------------------


On Dec. 21, 2015, 8:24 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126460/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 8:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> https://git.reviewboard.kde.org/r/126459/ introduced new
> flag that allows to skip the grouping of notifications.
> 
> This patch adapts the notifications server to that change.
> 
> 
> Diffs
> -----
> 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151221/d34cf0a4/attachment.html>