Review Request 126460: Honor SkipGrouping hint from KNotification
Martin Klapetek
martin.klapetek at gmail.com
Mon Dec 21 20:43:41 UTC 2015
> On Dec. 21, 2015, 9:38 p.m., David Edmundson wrote:
> > This does seem like a much better way to handle the grouping, so I'll +1 this.
> >
> > But as for the actual bug that brought you here:
> > Why are we getting two notifications for everything from Plasma in the first place?
Those are I think two slightly different issues.
The lock-widgets one is I think because of multiscreen, cause
then you have two containments emitting two same notifications.
The other one, which you marked that^ as duplicate of, is likely
a combo of bug 346622 and possibly also a multiscreen thing.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126460/#review89855
-----------------------------------------------------------
On Dec. 21, 2015, 9:24 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126460/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 9:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> https://git.reviewboard.kde.org/r/126459/ introduced new
> flag that allows to skip the grouping of notifications.
>
> This patch adapts the notifications server to that change.
>
>
> Diffs
> -----
>
> dataengines/notifications/notificationsengine.cpp 829ef4e
>
> Diff: https://git.reviewboard.kde.org/r/126460/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151221/d37f0f1c/attachment.html>
More information about the Plasma-devel
mailing list