Review Request 126432: [Containment Actions] Send along a proper wheel orientation

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126432/#review89780
-----------------------------------------------------------

Ship it!


Thanks


shell/currentcontainmentactionsmodel.cpp (line 92)
<https://git.reviewboard.kde.org/r/126432/#comment61550>

    instead of:
    
    abs(x) - abs(y) > 0
    
    abs(x) > abs(y)
    
    is considerably easier to read and does the same thing.


- David Edmundson


On Dec. 20, 2015, 2:28 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126432/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2015, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 356799
>     https://bugs.kde.org/show_bug.cgi?id=356799
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The orientation for wheel events is deprecated but this is a quick and easy fix to the problem without refactoring that entire thing.
> 
> 
> Diffs
> -----
> 
>   shell/currentcontainmentactionsmodel.cpp fe1c676 
> 
> Diff: https://git.reviewboard.kde.org/r/126432/diff/
> 
> 
> Testing
> -------
> 
> I can now assign actions to horizontal wheel and trigger them accordingly.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151220/792c49f1/attachment.html>