<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126432/">https://git.reviewboard.kde.org/r/126432/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126432/diff/1/?file=424842#file424842line92" style="color: black; font-weight: bold; text-decoration: underline;">shell/currentcontainmentactionsmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString CurrentContainmentActionsModel::mouseEventString(int mouseButton, int modifiers)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QWheelEvent</span> <span class="o">*</span><span class="n">wheel</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QWheelEvent</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(),</span> <span class="n">QPointF</span><span class="p">(),</span> <span class="n">delta</span><span class="p">.</span><span class="n">toPoint</span><span class="p">(),</span> <span class="n">QPoint</span><span class="p">(),</span> <span class="mi">0</span><span class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">Vertical</span><span class="p">,</span> <span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">MouseButtons</span><span class="p">)</span><span class="n">mouseButtons</span><span class="p">,</span> <span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">KeyboardModifiers</span><span class="p">)</span> <span class="n">modifiers</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QWheelEvent</span> <span class="o">*</span><span class="n">wheel</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QWheelEvent</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(),</span> <span class="n">QPointF</span><span class="p">(),</span> <span class="n">delta</span><span class="p">.</span><span class="n">toPoint</span><span class="p">(),</span> <span class="n">QPoint</span><span class="p">(),</span> <span class="mi">0</span><span class="p">,</span> <span class="n"><span class="hl">qAbs</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">delta</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">x</span></span><span class="p"><span class="hl">())</span></span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="hl"> </span><span class="n"><span class="hl">qAbs</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">delta</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">y</span></span><span class="p"><span class="hl">())</span></span><span class="hl"> </span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="hl"> </span><span class="o"><span class="hl">?</span></span><span class="hl"> </span><span class="n"><span class="hl">Qt</span></span><span class="o"><span class="hl">::</span></span><span class="nl"><span class="hl">Horizontal</span></span><span class="hl"> </span><span class="p"><span class="hl">:</span></span><span class="hl"> </span><span class="n">Qt</span><span class="o">::</span><span class="n">Vertical</span><span class="p">,</span> <span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">MouseButtons</span><span class="p">)</span><span class="n">mouseButtons</span><span class="p">,</span> <span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">KeyboardModifiers</span><span class="p">)</span> <span class="n">modifiers</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">instead of:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">abs(x) - abs(y) > 0</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">abs(x) > abs(y)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is considerably easier to read and does the same thing.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On December 20th, 2015, 2:28 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2015, 2:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=356799">356799</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The orientation for wheel events is deprecated but this is a quick and easy fix to the problem without refactoring that entire thing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can now assign actions to horizontal wheel and trigger them accordingly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/currentcontainmentactionsmodel.cpp <span style="color: grey">(fe1c676)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126432/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>