Review Request 126348: Make it possible to provide the metadata in json

Aleix Pol Gonzalez aleixpol at kde.org
Tue Dec 15 15:24:20 UTC 2015



> On Dec. 14, 2015, 10:50 p.m., Sebastian Kügler wrote:
> > src/kpackage/private/packagejobthread.cpp, line 189
> > <https://git.reviewboard.kde.org/r/126348/diff/1/?file=422766#file422766line189>
> >
> >     Why this change?

because currently it's not a text file. I can commit separately if you want.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/#review89499
-----------------------------------------------------------


On Dec. 14, 2015, 6:11 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126348/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 6:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Due to KCoreAddons transition from using desktop files to json files, KPackage ended in a weird state where desktop files were allowed to use desktop files but not json.
> 
> This patch makes sure that manifest.json files are also acceptable.
> 
> 
> Diffs
> -----
> 
>   autotests/querytest.cpp 0a2f11a 
>   src/kpackage/package.cpp 8416054 
>   src/kpackage/packageloader.cpp 1e1e382 
>   src/kpackage/private/packagejobthread.cpp 444dacc 
>   src/kpackage/private/packagejobthread_p.h 1babf0b 
>   src/kpackage/private/packages.cpp 2f6bbcf 
> 
> Diff: https://git.reviewboard.kde.org/r/126348/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass (except for https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, that is not passing in master).
> Adds a test plugin with a json file in it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151215/d1a5ab3a/attachment.html>


More information about the Plasma-devel mailing list