Review Request 126348: Make it possible to provide the metadata in json

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/#review89499
-----------------------------------------------------------



src/kpackage/package.cpp (line 447)
<https://git.reviewboard.kde.org/r/126348/#comment61251>

    Please remove before committing



src/kpackage/private/packagejobthread.cpp (line 138)
<https://git.reviewboard.kde.org/r/126348/#comment61252>

    So if this is going into KPluginMetaData, as Alex suggests, this part can be simplified



src/kpackage/private/packagejobthread.cpp (line 160)
<https://git.reviewboard.kde.org/r/126348/#comment61253>

    Would it make sense to make this stringlist a static as to share the data?



src/kpackage/private/packagejobthread.cpp (line 183)
<https://git.reviewboard.kde.org/r/126348/#comment61254>

    Why this change?



src/kpackage/private/packagejobthread.cpp (line 303)
<https://git.reviewboard.kde.org/r/126348/#comment61255>

    Above, we're using QStringLiteral() for the desktop file names, please make it consistent in the code you change, and in new code. Right now, it's a bit of a hodge-podge of QL1S, QSL, and just plain chars.



src/kpackage/private/packagejobthread.cpp (line 312)
<https://git.reviewboard.kde.org/r/126348/#comment61256>

    Not sure we should assert here, not loading a package is fine, and I'd rather not generate a crash (had to fix too many of these). Below, we're actually checking for valid metadata.
    
    Can we make it a warning?



src/kpackage/private/packagejobthread_p.h (line 59)
<https://git.reviewboard.kde.org/r/126348/#comment61258>

    We should be able to get rid of this one (and the additionally include in its user).



src/kpackage/private/packages.cpp (line 57)
<https://git.reviewboard.kde.org/r/126348/#comment61257>

    Fix spelling of "Fuck" and make it a fatal error? ;)


- Sebastian Kügler


On Dec. 14, 2015, 5:11 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126348/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Due to KCoreAddons transition from using desktop files to json files, KPackage ended in a weird state where desktop files were allowed to use desktop files but not json.
> 
> This patch makes sure that manifest.json files are also acceptable.
> 
> 
> Diffs
> -----
> 
>   autotests/querytest.cpp 0a2f11a 
>   src/kpackage/package.cpp 8416054 
>   src/kpackage/packageloader.cpp 1e1e382 
>   src/kpackage/private/packagejobthread.cpp 444dacc 
>   src/kpackage/private/packagejobthread_p.h 1babf0b 
>   src/kpackage/private/packages.cpp 2f6bbcf 
> 
> Diff: https://git.reviewboard.kde.org/r/126348/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass (except for https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, that is not passing in master).
> Adds a test plugin with a json file in it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151214/c28edd58/attachment-0001.html>