Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126349/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 1:15 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
-------

This adds a global function qreal screenPixelRatio(int screen) to the desktop scripting API to complement screenGeometry(). Since we don't do per-screen scaling in Plasma currently the implementation ignores the argument. It's otherwise matching Units::devicePixelRatio.

If this becomes available, I can use it in the default panel layout script to scale the default panel thickness, which is currently unscaled - i.e. when Plasma scales up on a hi-dpi screen the panel will be initialized to be tiny anyway, which is a pretty egregrious papercut on hidpi systems.


Diffs
-----

  shell/scripting/appinterface.h 93aa014 
  shell/scripting/appinterface.cpp 2c54f1e 

Diff: https://git.reviewboard.kde.org/r/126349/diff/


Testing
-------

Adjusted layout script, determined it works nicely.


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151215/c1aae55c/attachment.html>