Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

[Martin Klapetek]

Hey,

On Thu, Dec 10, 2015 at 2:54 PM, Maximiliano Curia <maxy at gnuservers.com.ar>
wrote:

> Hi,
>
> Sorry that I haven't seen this review before plasma 5.5 was released
> (containing this change), but pam modules are traditionally installed in
> /lib,
> that is, with an empty prefix. In the same CMakeLists.txt you can read the
> intention to honor this:
> set_target_properties (${library_name} PROPERTIES PREFIX "")
>
> Sadly, this alone is not sufficient, thus the / in the install rule.
>
> This change forces me to introduce the attached patch in the Debian
> package,
> as pam modules should be available even if /usr is not mounted.
>

Thanks for getting in touch!

However if I'm not mistaken, that set_target_properties call does not
do what you imply it does. Setting empty PREFIX means that it will
not prepend "lib" to the filename, eg. "libpam_kwallet.so", but will instead
name it "pam_kwallet.so".

It has nothing to do with install paths.

If you want to have it installed in /lib, just set CMAKE_INSTALL_PREFIX
to "/", then it should install into /lib correctly.

Cheers
-- 
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151210/6672f03f/attachment.html>