Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

Eike Hein hein at kde.org
Thu Dec 3 18:12:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/
-----------------------------------------------------------

(Updated Dec. 3, 2015, 6:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Elvis Angelaccio.


Changes
-------

Submitted with commit fa467314a39d596ab7bd785ced637f599c4055ba by Eike Hein to branch Applications/15.12.


Bugs: 294904
    http://bugs.kde.org/show_bug.cgi?id=294904


Repository: ark


Description
-------

Ark's D-Bus service only supports extraction to local paths, which breaks dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO properly (difficult though since not all the backend tools ultimately support it, etc.), but in lieu of that I think it's best to resolve to a local path whenever possible on the Ark side, since otherwise it has to be done in all the callers (aside from FV we also have Dolphin).

See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html


Diffs
-----

  part/part.cpp 240b628 

Diff: https://git.reviewboard.kde.org/r/126233/diff/


Testing
-------


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151203/9956ad56/attachment.html>


More information about the Plasma-devel mailing list