Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

Elvis Angelaccio elvis.angelaccio at kdemail.net
Thu Dec 3 17:52:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/#review89091
-----------------------------------------------------------

Ship it!


Thanks for working on this!
This patch does fix bug 294904 [1], so you could even commit it to Applications/15.12 branch.

[1]: https://bugs.kde.org/show_bug.cgi?id=294904

- Elvis Angelaccio


On Dec. 3, 2015, 5:29 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126233/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 5:29 p.m.)
> 
> 
> Review request for Plasma and Elvis Angelaccio.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Ark's D-Bus service only supports extraction to local paths, which breaks dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO properly (difficult though since not all the backend tools ultimately support it, etc.), but in lieu of that I think it's best to resolve to a local path whenever possible on the Ark side, since otherwise it has to be done in all the callers (aside from FV we also have Dolphin).
> 
> See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html
> 
> 
> Diffs
> -----
> 
>   part/part.cpp 240b628 
> 
> Diff: https://git.reviewboard.kde.org/r/126233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151203/49a0aa3a/attachment.html>


More information about the Plasma-devel mailing list