Review Request 126221: Rework the notifications positioning a bit

[Martin Klapetek]

> On Dec. 2, 2015, 5:17 p.m., David Edmundson wrote:
> > applets/notifications/lib/notificationsapplet.cpp, line 46
> > <https://git.reviewboard.kde.org/r/126221/diff/1/?file=420694#file420694line46>
> >
> >     what about when it's just "Left" or "Right" ?

It's not, ever. http://paste.opensuse.org/view/raw/abc75d49


> On Dec. 2, 2015, 5:17 p.m., David Edmundson wrote:
> > applets/notifications/plugin/notificationshelper.cpp, line 73
> > <https://git.reviewboard.kde.org/r/126221/diff/1/?file=420697#file420697line73>
> >
> >     what if it's "Default" and the panel happens to be top?

This is resolved in NotificationsApplet::onAppletLocationChanged (connected to Plasma::Applet::locationChanged; which is emitted on applet load). So when it's Default, the applet follows the panel and resolves the value to one of the actual values (Top* or Bottom*).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126221/#review89049
-----------------------------------------------------------


On Dec. 2, 2015, 5:07 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126221/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 5:07 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355069
>     https://bugs.kde.org/show_bug.cgi?id=355069
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The notifications popup positioning recently regressed
> by some other changes (looks like Qt) and the popups
> would fly across the screen (bug 355069).
> 
> The proper solution is using KWin effect but given how
> close the release is, this needs to be dealt with in a
> different way.
> 
> The main problem is calculating the initial popup size
> because as long as the Dialog is invisible, it has an
> incorrect geometry, so it needs to be positioned right
> after it's being displayed. The Dialog however gets the
> sizes even later, so the code now calls a slot from Dialog
> that ensures the sizes are correct before the initial
> placement on screen. It's not ideal but I'm out of ideas
> otherwise. Plus it should be only temporary until the
> KWin effect will replace it.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/Notifications.qml 306169c 
>   applets/notifications/lib/notificationsapplet.cpp aa50aef 
>   applets/notifications/lib/notificationsapplet.h dc31e1d 
>   applets/notifications/plugin/notificationshelper.h cb9b335 
>   applets/notifications/plugin/notificationshelper.cpp 7c0dd99 
> 
> Diff: https://git.reviewboard.kde.org/r/126221/diff/
> 
> 
> Testing
> -------
> 
> I can no longer reproduce notifications flying across
> the screen.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151202/05f99be9/attachment.html>