Review Request 126221: Rework the notifications positioning a bit
David Edmundson
david at davidedmundson.co.uk
Wed Dec 2 16:17:11 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126221/#review89049
-----------------------------------------------------------
applets/notifications/lib/notificationsapplet.cpp (line 46)
<https://git.reviewboard.kde.org/r/126221/#comment60966>
what about when it's just "Left" or "Right" ?
applets/notifications/plugin/notificationshelper.cpp (line 73)
<https://git.reviewboard.kde.org/r/126221/#comment60965>
what if it's "Default" and the panel happens to be top?
applets/notifications/plugin/notificationshelper.cpp (line 143)
<https://git.reviewboard.kde.org/r/126221/#comment60964>
use the static version:
http://doc.qt.io/qt-5/qmetaobject.html#invokeMethod all this becomes 1 line
- David Edmundson
On Dec. 2, 2015, 4:07 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126221/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 4:07 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 355069
> https://bugs.kde.org/show_bug.cgi?id=355069
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The notifications popup positioning recently regressed
> by some other changes (looks like Qt) and the popups
> would fly across the screen (bug 355069).
>
> The proper solution is using KWin effect but given how
> close the release is, this needs to be dealt with in a
> different way.
>
> The main problem is calculating the initial popup size
> because as long as the Dialog is invisible, it has an
> incorrect geometry, so it needs to be positioned right
> after it's being displayed. The Dialog however gets the
> sizes even later, so the code now calls a slot from Dialog
> that ensures the sizes are correct before the initial
> placement on screen. It's not ideal but I'm out of ideas
> otherwise. Plus it should be only temporary until the
> KWin effect will replace it.
>
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/Notifications.qml 306169c
> applets/notifications/lib/notificationsapplet.cpp aa50aef
> applets/notifications/lib/notificationsapplet.h dc31e1d
> applets/notifications/plugin/notificationshelper.h cb9b335
> applets/notifications/plugin/notificationshelper.cpp 7c0dd99
>
> Diff: https://git.reviewboard.kde.org/r/126221/diff/
>
>
> Testing
> -------
>
> I can no longer reproduce notifications flying across
> the screen.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151202/ef731f66/attachment.html>
More information about the Plasma-devel
mailing list