Review Request 109684: Make code python3 compatible.

[Michael Jansen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109684/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 10:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Luca Beltrame.


Repository: kde-workspace


Description
-------

Make code python3 compatible.

>From the python 2.7 docs:

  The form exec(expr, globals) is equivalent to exec expr in globals, while
  the form exec(expr, globals, locals) is equivalent to exec expr in globals,
  locals. The tuple form of exec provides compatibility with Python 3, where
  exec is a function rather than a statement


But this only work with python 2.7. Version up to 2.6 do not have this behavior so i fully expect this review request to be rejected. But i wanted to open the discussion because its not easy to fix.

The syntax needed for version <= 2.6  is incompatible with versions >3.0 and no amount of code wizardry will help us here. We either require python 2.7 or have to duplicate, configure or whatever this script to match the python version used on build time. Or perhaps refactor the code to use eval?

Which way to go?


Diffs
-----

  plasma/generic/scriptengines/python/plasma_importer.py dae245aea1ea1d17c907ba9c12c7d06cc9e59b77 

Diff: https://git.reviewboard.kde.org/r/109684/diff/


Testing
-------

Not much yet. Works with 3.0 but i have no clue what that code does or how to test it.


Thanks,

Michael Jansen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/854797f7/attachment.html>