<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109684/">https://git.reviewboard.kde.org/r/109684/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Luca Beltrame.</div>
<div>By Michael Jansen.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2015, 10:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make code python3 compatible.
>From the python 2.7 docs:
The form exec(expr, globals) is equivalent to exec expr in globals, while
the form exec(expr, globals, locals) is equivalent to exec expr in globals,
locals. The tuple form of exec provides compatibility with Python 3, where
exec is a function rather than a statement
But this only work with python 2.7. Version up to 2.6 do not have this behavior so i fully expect this review request to be rejected. But i wanted to open the discussion because its not easy to fix.
The syntax needed for version <= 2.6 is incompatible with versions >3.0 and no amount of code wizardry will help us here. We either require python 2.7 or have to duplicate, configure or whatever this script to match the python version used on build time. Or perhaps refactor the code to use eval?
Which way to go?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not much yet. Works with 3.0 but i have no clue what that code does or how to test it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/scriptengines/python/plasma_importer.py <span style="color: grey">(dae245aea1ea1d17c907ba9c12c7d06cc9e59b77)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109684/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>