Review Request 124996: Update struts on screen size change

Andrew Chen andrew.chuanye.chen at gmail.com
Mon Aug 31 08:09:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124996/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 8:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
-------

Submitted with commit d66d6d57d34f3fc46a1cb7886f06dfe5b7a61763 by David Edmundson on behalf of Andrew Chen to branch Plasma/5.4.


Bugs: 349400
    https://bugs.kde.org/show_bug.cgi?id=349400


Repository: plasma-workspace


Description
-------

Calls updateStruts on KScreen::Screen::currentSizeChanged instead of KScreen::Config::outputAdded/outputRemoved.
When an output is (dis)conencted, it isn't added/removed, it is mearly marked as (dis)connected. Therefore, updating struts on outputAdded/outputRemoved doesn't work.


Diffs
-----

  shell/panelview.cpp f67ae7dec55b8c14825c0f76014155f2132fbcae 

Diff: https://git.reviewboard.kde.org/r/124996/diff/


Testing
-------

Struts now correctly update whenever the screen size changes, e.g. (dis)connection of output, change in resolution.


Thanks,

Andrew Chen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/f9fb74cf/attachment.html>


More information about the Plasma-devel mailing list