Review Request 124996: Update struts on screen size change
David Edmundson
david at davidedmundson.co.uk
Mon Aug 31 07:31:37 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124996/#review84621
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Aug. 31, 2015, 6:07 a.m., Andrew Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124996/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 6:07 a.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Bugs: 349400
> https://bugs.kde.org/show_bug.cgi?id=349400
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Calls updateStruts on KScreen::Screen::currentSizeChanged instead of KScreen::Config::outputAdded/outputRemoved.
> When an output is (dis)conencted, it isn't added/removed, it is mearly marked as (dis)connected. Therefore, updating struts on outputAdded/outputRemoved doesn't work.
>
>
> Diffs
> -----
>
> shell/panelview.cpp f67ae7dec55b8c14825c0f76014155f2132fbcae
>
> Diff: https://git.reviewboard.kde.org/r/124996/diff/
>
>
> Testing
> -------
>
> Struts now correctly update whenever the screen size changes, e.g. (dis)connection of output, change in resolution.
>
>
> Thanks,
>
> Andrew Chen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/e9635ebf/attachment-0001.html>
More information about the Plasma-devel
mailing list