Review Request 124986: [System Tray] Bring back shortcuts configuration

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124986/#review84598
-----------------------------------------------------------

Ship it!


code seems fine, ship it when we've sorted out Thomas' comment


applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h (line 54)
<https://git.reviewboard.kde.org/r/124986/#comment58546>

    95% sure this won't work from QML
    
    However, it's also not used.
    
    it was used in StatusNotifierItem.qml
    
    //     Connections {
    //         target: task
    //
    //         onChangedShortcut: {
    //             // update shortcut for icon widget
    //             if (!icon_widget.action)
    //                 return
    //             plasmoid.updateShortcutAction(icon_widget.action, task.shortcut)
    //             icon_widget.action.triggered.disconnect(__onActivatedShortcut) // disconnect old signals
    //             icon_widget.action.triggered.connect(__onActivatedShortcut)
    //         }
    //
    //         onShowContextMenu: plasmoid.showMenu(menu, x, y, root_item)
    //     }
    
    I suggest killing the code here and removing this as a property.


- David Edmundson


On Aug. 29, 2015, 9:25 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124986/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 9:25 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In Plasma 4.x you could configure applet shortcuts from System Tray settings rather fiddling around with each individual applet. This restores this.
> 
> - It uses a TableView like the 4.x did (TableView is a good candidate for pushing ComboBox off its throne of horribleness), including the item's icon
> - Shortcuts in System Tray are now handled through QKeySequence rather than QString
> - When checking "Always show all entries" the comboboxes become disabled (not the entire Table so you could still change shortcuts)
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/ConfigEntries.qml e848ae3 
>   applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h f499a57 
>   applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 6486f18 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h 74d1e1f 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 1528c7a 
> 
> Diff: https://git.reviewboard.kde.org/r/124986/diff/
> 
> 
> Testing
> -------
> 
> I can set and unset applet shortcuts (did we have that for DBus tasks? There were stubs for that but I can't remember), as well as hide/show/auto entries.
> 
> 
> File Attachments
> ----------------
> 
> UI in action
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/29/795452f7-f817-49d5-a2bb-ba43234f4f91__systemtrayshortcuts.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150830/96f9faf6/attachment.html>