<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124986/">https://git.reviewboard.kde.org/r/124986/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">code seems fine, ship it when we've sorted out Thomas' comment</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124986/diff/2/?file=399623#file399623line54" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace SystemTray</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">Q<span class="hl">String</span></span> <span class="n">shortcut</span> <span class="n">READ</span> <span class="n">shortcut</span> <span class="n">NOTIFY</span> <span class="n">changedShortcut</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">Q<span class="hl">KeySequence</span></span> <span class="n">shortcut</span> <span class="n">READ</span> <span class="n">s<span class="hl">hortcut</span></span><span class="hl"> </span><span class="n"><span class="hl">WRITE</span></span><span class="hl"> </span><span class="n"><span class="hl">setS</span>hortcut</span> <span class="n">NOTIFY</span> <span class="n">changedShortcut</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">95% sure this won't work from QML</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However, it's also not used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it was used in StatusNotifierItem.qml</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">// Connections {
// target: task
//
// onChangedShortcut: {
// // update shortcut for icon widget
// if (!icon_widget.action)
// return
// plasmoid.updateShortcutAction(icon_widget.action, task.shortcut)
// icon_widget.action.triggered.disconnect(<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">onActivatedShortcut) // disconnect old signals
// icon_widget.action.triggered.connect(</strong>onActivatedShortcut)
// }
//
// onShowContextMenu: plasmoid.showMenu(menu, x, y, root_item)
// }</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggest killing the code here and removing this as a property.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On August 29th, 2015, 9:25 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2015, 9:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In Plasma 4.x you could configure applet shortcuts from System Tray settings rather fiddling around with each individual applet. This restores this.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">It uses a TableView like the 4.x did (TableView is a good candidate for pushing ComboBox off its throne of horribleness), including the item's icon</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Shortcuts in System Tray are now handled through QKeySequence rather than QString</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">When checking "Always show all entries" the comboboxes become disabled (not the entire Table so you could still change shortcuts)</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can set and unset applet shortcuts (did we have that for DBus tasks? There were stubs for that but I can't remember), as well as hide/show/auto entries.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/ui/ConfigEntries.qml <span style="color: grey">(e848ae3)</span></li>
<li>applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h <span style="color: grey">(f499a57)</span></li>
<li>applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp <span style="color: grey">(6486f18)</span></li>
<li>applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h <span style="color: grey">(74d1e1f)</span></li>
<li>applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp <span style="color: grey">(1528c7a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124986/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/29/795452f7-f817-49d5-a2bb-ba43234f4f91__systemtrayshortcuts.png">UI in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>