Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster

Martin Gräßlin mgraesslin at kde.org
Wed Aug 26 10:04:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124930/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 12:04 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
-------

In a multi-screen setup we have multiple views showing the same Qml
scene. Let's share the engine for all views.

[screenlocker] Use one QQmlComponent for all views

No need to parse the same Qml file multiple times (for each screen).
Instead use one QQmlComponent and create a QQuickItem for each screen.


Diffs
-----

  ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 
  ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c 

Diff: https://git.reviewboard.kde.org/r/124930/diff/


Testing
-------

Not yet tested the fallback.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/60e29253/attachment.html>


More information about the Plasma-devel mailing list