Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124930/#review84397
-----------------------------------------------------------


I can't imagine the component sharing this makes any difference there's a global component cache anyway. It won't compile the same file twice.

Unless you know better, I wouldn't make that change.


ksmserver/screenlocker/greeter/greeterapp.cpp (line 185)
<https://git.reviewboard.kde.org/r/124930/#comment58432>

    This change will make a difference.
    
    Though, if we're sharing the engine maybe we can use Marco's shiny new QuickViewSharedEngine. It does the engine part implicitly but handles roobObjects and such better.
    
    The engine manipulation above would change to KDeclarative::QmlObjectSharedEngine


- David Edmundson


On Aug. 26, 2015, 9:24 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124930/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 9:24 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In a multi-screen setup we have multiple views showing the same Qml
> scene. Let's share the engine for all views.
> 
> [screenlocker] Use one QQmlComponent for all views
> 
> No need to parse the same Qml file multiple times (for each screen).
> Instead use one QQmlComponent and create a QQuickItem for each screen.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 
>   ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c 
> 
> Diff: https://git.reviewboard.kde.org/r/124930/diff/
> 
> 
> Testing
> -------
> 
> Not yet tested the fallback.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/4131099c/attachment.html>