Review Request 124910: Make model param of clicked signal of var type

Kai Uwe Broulik kde at privat.broulik.de
Wed Aug 26 08:46:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124910/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 8:46 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 6995193219a64fd2bce73108fbfca25a5cc7e99b by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

When using ModelContextMenu with a JS array the "model" param of the clicked signal is null because QtObject property can only hold QObject but no JS objects.


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml baa541a 

Diff: https://git.reviewboard.kde.org/r/124910/diff/


Testing
-------

Works. Will make a ModelContextMenu test at some point.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/5e3cd0da/attachment.html>


More information about the Plasma-devel mailing list