Review Request 124910: Make model param of clicked signal of var type

Marco Martin notmart at gmail.com
Wed Aug 26 08:35:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124910/#review84395
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 24, 2015, 9:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124910/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 9:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When using ModelContextMenu with a JS array the "model" param of the clicked signal is null because QtObject property can only hold QObject but no JS objects.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml baa541a 
> 
> Diff: https://git.reviewboard.kde.org/r/124910/diff/
> 
> 
> Testing
> -------
> 
> Works. Will make a ModelContextMenu test at some point.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/9445f9b8/attachment-0001.html>


More information about the Plasma-devel mailing list