Review Request 124874: Fix lockup in digital clock

David Edmundson david at davidedmundson.co.uk
Sat Aug 22 10:35:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124874/
-----------------------------------------------------------

(Updated Aug. 22, 2015, 10:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit fa6b5576f5243d147c1280904c967408b4ce5a0b by David Edmundson to branch Plasma/5.4.


Repository: plasma-workspace


Description
-------

property tooSmall depends on height

If it's tool small it changes what text is shown on top of each other
Whether text is shown changes the height; super complex binding loop
that because it throws in a visibility change and goes via layouts isn't
being caught.

>From what I can tell of other code when vertical we always want to show
both bits of text.

BUG: 351479


Diffs
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml 475ec9733a12abe2f0ced36016215ebd6adf9253 

Diff: https://git.reviewboard.kde.org/r/124874/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150822/da7f32af/attachment.html>


More information about the Plasma-devel mailing list