Review Request 124845: Port KDED plugins to json metadata

David Edmundson david at davidedmundson.co.uk
Thu Aug 20 19:43:59 UTC 2015



> On Aug. 20, 2015, 7:05 p.m., David Edmundson wrote:
> > you're awesome.
> > 
> > as this changes targets, master only please
> 
> Ragnar Thomsen wrote:
>     Thanks :) Can I commit it now or should I wait for further Ship it's?

now is fine


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124845/#review84107
-----------------------------------------------------------


On Aug. 20, 2015, 6:57 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124845/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 6:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch ports all remaining KDED modules in plasma-workspace to json metadata and disables installation of the desktop files.
> 
> The plugins now get installed in ${KDE_INSTALL_PLUGINDIR}/kf5/kded and the `kded_` prefix is removed.
> 
> 
> Diffs
> -----
> 
>   systemmonitor/kdedksysguard.cpp 83b6876 
>   systemmonitor/CMakeLists.txt ab189f8 
>   statusnotifierwatcher/statusnotifierwatcher.cpp 3a9fcdc 
>   statusnotifierwatcher/CMakeLists.txt bd6a82b 
>   soliduiserver/CMakeLists.txt 0a8ed6b 
>   solidautoeject/solidautoeject.cpp 9709e74 
>   solidautoeject/CMakeLists.txt c6661eb 
>   ktimezoned/CMakeLists.txt d7e3e01 
>   kioslave/remote/kdedmodule/remotedirnotifymodule.cpp 38676e7 
>   kioslave/remote/kdedmodule/CMakeLists.txt deae484 
>   freespacenotifier/freespacenotifier.desktop 1b170da 
>   appmenu/CMakeLists.txt 9567056 
>   appmenu/appmenu.cpp d5620fa 
>   freespacenotifier/CMakeLists.txt aa08386 
> 
> Diff: https://git.reviewboard.kde.org/r/124845/diff/
> 
> 
> Testing
> -------
> 
> All modules are loaded successfully.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150820/50f9c672/attachment.html>


More information about the Plasma-devel mailing list