<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124845/">https://git.reviewboard.kde.org/r/124845/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2015, 7:05 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you're awesome.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as this changes targets, master only please</p></pre>
</blockquote>
<p>On August 20th, 2015, 7:23 p.m. UTC, <b>Ragnar Thomsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks :) Can I commit it now or should I wait for further Ship it's?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">now is fine</p></pre>
<br />
<p>- David</p>
<br />
<p>On August 20th, 2015, 6:57 p.m. UTC, Ragnar Thomsen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ragnar Thomsen.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2015, 6:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch ports all remaining KDED modules in plasma-workspace to json metadata and disables installation of the desktop files.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The plugins now get installed in ${KDE_INSTALL_PLUGINDIR}/kf5/kded and the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kded_</code> prefix is removed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All modules are loaded successfully.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>systemmonitor/kdedksysguard.cpp <span style="color: grey">(83b6876)</span></li>
<li>systemmonitor/CMakeLists.txt <span style="color: grey">(ab189f8)</span></li>
<li>statusnotifierwatcher/statusnotifierwatcher.cpp <span style="color: grey">(3a9fcdc)</span></li>
<li>statusnotifierwatcher/CMakeLists.txt <span style="color: grey">(bd6a82b)</span></li>
<li>soliduiserver/CMakeLists.txt <span style="color: grey">(0a8ed6b)</span></li>
<li>solidautoeject/solidautoeject.cpp <span style="color: grey">(9709e74)</span></li>
<li>solidautoeject/CMakeLists.txt <span style="color: grey">(c6661eb)</span></li>
<li>ktimezoned/CMakeLists.txt <span style="color: grey">(d7e3e01)</span></li>
<li>kioslave/remote/kdedmodule/remotedirnotifymodule.cpp <span style="color: grey">(38676e7)</span></li>
<li>kioslave/remote/kdedmodule/CMakeLists.txt <span style="color: grey">(deae484)</span></li>
<li>freespacenotifier/freespacenotifier.desktop <span style="color: grey">(1b170da)</span></li>
<li>appmenu/CMakeLists.txt <span style="color: grey">(9567056)</span></li>
<li>appmenu/appmenu.cpp <span style="color: grey">(d5620fa)</span></li>
<li>freespacenotifier/CMakeLists.txt <span style="color: grey">(aa08386)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124845/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>