Review Request 124792: Fix desktop context property for Desktop.qml

David Edmundson david at davidedmundson.co.uk
Mon Aug 17 16:14:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124792/
-----------------------------------------------------------

(Updated Aug. 17, 2015, 4:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 9feaf37e93231e6c9410d0a585011731c4a33ff2 by David Edmundson to branch Plasma/5.4.


Repository: plasma-workspace


Description
-------

This is fallout from the shared engine changes.

With the shared view, engine()->rootContext() is not the same as
rootContext(). One being global, the other being per window.

This resulted us in us overwriting the same "desktop" context property,
and so Desktop.qml always had the property desktop pointing to the last
created desktop view.

The most obvious symptom is that the add widgets dialog appeared on the
wrong screen.

BUG: 351292


Diffs
-----

  shell/desktopview.cpp f52c40d6a98127dbe8f46a38e476500eb6b5bef5 

Diff: https://git.reviewboard.kde.org/r/124792/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150817/3f1d176e/attachment.html>


More information about the Plasma-devel mailing list