Review Request 124509: Use small button for session combo

[Thomas Pfeiffer]

> On Aug. 4, 2015, 12:22 a.m., Thomas Pfeiffer wrote:
> > Thanks for taking this up so fast!
> > Let me check back with our icon designers regarding whether this is the best icon for that button (it always looked more like a settings icon than a menu icon to me). Otherwise, the button seems fine.
> > I assume the fact that in the screenshot, the height of the edit box and the login button are different is unrelated tot his patch, right?
> 
> Kai Uwe Broulik wrote:
>     Yes, that is unrelated but I think I should fix that too. Though it's probably just in test mode that the difference is as significant as in the screen shot.

Please use the toolbar/application-menu icon for the button.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124509/#review83406
-----------------------------------------------------------


On Aug. 13, 2015, 8:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124509/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 8:09 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As discussed with the VDG since it's a more of a power user feature
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml 065a115 
> 
> Diff: https://git.reviewboard.kde.org/r/124509/diff/
> 
> 
> Testing
> -------
> 
> Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?)
> 
> 
> File Attachments
> ----------------
> 
> Login screen
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150813/b9bc565b/attachment.html>