Review Request 124509: Use small button for session combo

Kai Uwe Broulik kde at privat.broulik.de
Thu Aug 13 20:08:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124509/
-----------------------------------------------------------

(Updated Aug. 13, 2015, 8:08 nachm.)


Review request for Plasma and KDE Usability.


Changes
-------

Use ToolButton's menu property and attach a QQC Menu there.

Unfortunately ExclusiveGroup's "current" property is a QQuickAction representing the menu action rather than the menu item itself hence I need to manually override the sessionIndex when the item becomes checked.


Repository: plasma-workspace


Description
-------

As discussed with the VDG since it's a more of a power user feature


Diffs (updated)
-----

  lookandfeel/contents/loginmanager/Main.qml 065a115 

Diff: https://git.reviewboard.kde.org/r/124509/diff/


Testing
-------

Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?)


File Attachments
----------------

Login screen
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150813/e5b7a112/attachment.html>


More information about the Plasma-devel mailing list