Review Request 124647: Cmake fail to parse proper taglib version

[Rex Dieter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/#review83511
-----------------------------------------------------------


Wouldn't it be better to use VERSION_GREATER (http://www.cmake.org/cmake/help/v3.0/command/if.html) rather than a string compare?

- Rex Dieter


On Aug. 6, 2015, 4 p.m., Luca Sartorelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124647/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 4 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> taglib 1.4 is requested to build plasma-mediacenter
> but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure
> 
> 
> Diffs
> -----
> 
>   cmake/FindTaglib.cmake c23d582 
> 
> Diff: https://git.reviewboard.kde.org/r/124647/diff/
> 
> 
> Testing
> -------
> 
> Run cmake with kdesrc-build on debian strecth
> taglib version correctly found and parsed
> and plasma-mediacenter succesfully build
> 
> 
> File Attachments
> ----------------
> 
> MacroEnsureVersion.cmake
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/06/3d08277e-1803-4922-a61d-1c072beb7e35__MacroEnsureVersion.cmake
> 
> 
> Thanks,
> 
> Luca Sartorelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150806/90da4521/attachment-0001.html>