Review Request 124647: Cmake fail to parse proper taglib version

Luca Sartorelli dj3mb3 at gmail.com
Thu Aug 6 16:00:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-mediacenter


Description
-------

taglib 1.4 is requested to build plasma-mediacenter
but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure


Diffs
-----

  cmake/FindTaglib.cmake c23d582 

Diff: https://git.reviewboard.kde.org/r/124647/diff/


Testing
-------

Run cmake with kdesrc-build on debian strecth
taglib version correctly found and parsed
and plasma-mediacenter succesfully build


File Attachments
----------------

MacroEnsureVersion.cmake
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/06/3d08277e-1803-4922-a61d-1c072beb7e35__MacroEnsureVersion.cmake


Thanks,

Luca Sartorelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150806/f5f85e5e/attachment.html>


More information about the Plasma-devel mailing list