Review Request 124628: Fix loop on ButtonStyle

Aleix Pol Gonzalez aleixpol at kde.org
Wed Aug 5 16:33:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124628/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 4:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit f87f03b4a8dc95fc090d5a731a73a814179597ce by Aleix Pol to branch master.


Repository: plasma-framework


Description
-------

Nowadays the size of the icon is defined by the size of the button itself. And vice-versa.

This patch uses the unit sizes to decide which sizes to offer.


Diffs
-----

  src/declarativeimports/plasmastyle/ButtonStyle.qml ea64ba3 

Diff: https://git.reviewboard.kde.org/r/124628/diff/


Testing
-------

Fixes the display of an icon-only button in muon discover.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150805/214e7519/attachment.html>


More information about the Plasma-devel mailing list