Review Request 124628: Fix loop on ButtonStyle

Marco Martin notmart at gmail.com
Wed Aug 5 16:28:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124628/#review83463
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 5, 2015, 3:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124628/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 3:29 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Nowadays the size of the icon is defined by the size of the button itself. And vice-versa.
> 
> This patch uses the unit sizes to decide which sizes to offer.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml ea64ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/124628/diff/
> 
> 
> Testing
> -------
> 
> Fixes the display of an icon-only button in muon discover.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150805/2ec67873/attachment.html>


More information about the Plasma-devel mailing list