Review Request 124453: [digital-clock] Provide a simple option for 24h clock

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124453/#review83441
-----------------------------------------------------------



applets/digital-clock/package/contents/ui/DigitalClock.qml (line 470)
<https://git.reviewboard.kde.org/r/124453/#comment57669>

    this regexp won't work in Korean or Chinese.
    
    I made a list of all the possible values from the ICU file
    
    "a h:mm:ss"
    "ah:mm:ss"
    "HH:mm:ss"
    "HH.mm.ss"
    "H:mm:ss"
    "H.mm.ss"
    "h:mm:ss a"
    
    letters conversion here: http://www.unicode.org/reports/tr35/tr35-37/tr35-dates.html#Date_Field_Symbol_Table
    
    I think your regexp wants a "h" as the first letter.
    We can drop the '^' for a quick fix; though I guess we should also make sure the am/pm is on the correct side too.


- David Edmundson


On Aug. 3, 2015, 5:24 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124453/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 5:24 p.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Bugs: 345378
>     https://bugs.kde.org/show_bug.cgi?id=345378
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is _the_ most requested feature for the clock, simple checkbox for 24h clock.
> 
> In my opinion this is just a temporary workaround and not a very good one (generally,
> code-wise it's awesome :P). There should really be a global config option for that
> but as we now rely on QLocale and QLocale is...bad at this, here's at least this
> small help, which will at least change the clock format on the panel.
> 
> Imo we could really really use something like KLocale again.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/configAppearance.qml cc1acbe 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 696903a 
>   applets/digital-clock/package/contents/config/main.xml 8b0872b 
> 
> Diff: https://git.reviewboard.kde.org/r/124453/diff/
> 
> 
> Testing
> -------
> 
> Switching the checkbox on and off works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150804/ac1a317b/attachment.html>