Review Request 124453: [digital-clock] Provide a simple option for 24h clock

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124453/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 7:24 p.m.)


Review request for Plasma and Thomas Pfeiffer.


Changes
-------

Set default to locale default; it will use the PartiallyChecked state for the default value.


Bugs: 345378
    https://bugs.kde.org/show_bug.cgi?id=345378


Repository: plasma-workspace


Description
-------

This is _the_ most requested feature for the clock, simple checkbox for 24h clock.

In my opinion this is just a temporary workaround and not a very good one (generally,
code-wise it's awesome :P). There should really be a global config option for that
but as we now rely on QLocale and QLocale is...bad at this, here's at least this
small help, which will at least change the clock format on the panel.

Imo we could really really use something like KLocale again.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/configAppearance.qml cc1acbe 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 696903a 
  applets/digital-clock/package/contents/config/main.xml 8b0872b 

Diff: https://git.reviewboard.kde.org/r/124453/diff/


Testing
-------

Switching the checkbox on and off works as expected.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150803/e35ff71f/attachment.html>