Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

[David Edmundson]

> On Aug. 1, 2015, 9:46 a.m., Martin Klapetek wrote:
> > shell/main.cpp, line 49
> > <https://git.reviewboard.kde.org/r/124576/diff/1/?file=389034#file389034line49>
> >
> >     Does everything actually goes to stderr or should qDebug go to stdout?
> >     
> >     (I don't actually know but I always thought that's how it is)

it's always stderr. In fact I just copied and pasted this line from logging.cpp from Qt :D


> On Aug. 1, 2015, 9:46 a.m., Martin Klapetek wrote:
> > shell/main.cpp, line 43
> > <https://git.reviewboard.kde.org/r/124576/diff/1/?file=389034#file389034line43>
> >
> >     Should this be something like ".contans()"? Or is the message guaranteed to be always this?

It will always be like this unless Qt decide to change it one release. The error comes from xcb_glx, so it won't change per graphic card or anything.
(and as for wayland if they don't have openGL, they won't get this far anyway)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review83285
-----------------------------------------------------------


On Aug. 1, 2015, 9:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 9:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> -------
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150801/3e943bda/attachment.html>