Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review83285
-----------------------------------------------------------

Ship it!



shell/main.cpp (line 4)
<https://git.reviewboard.kde.org/r/124576/#comment57530>

    That's only half you



shell/main.cpp (line 43)
<https://git.reviewboard.kde.org/r/124576/#comment57531>

    Should this be something like ".contans()"? Or is the message guaranteed to be always this?



shell/main.cpp (line 49)
<https://git.reviewboard.kde.org/r/124576/#comment57532>

    Does everything actually goes to stderr or should qDebug go to stdout?
    
    (I don't actually know but I always thought that's how it is)



shell/main.cpp (line 102)
<https://git.reviewboard.kde.org/r/124576/#comment57533>

    "Deprecated, does nothing"? Deprecated usually still work, this won't anymore, so I'd add that note


- Martin Klapetek


On Aug. 1, 2015, 11:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> -------
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150801/a7f68f0e/attachment-0001.html>