Review Request 123570: Add a method to insert new known structures

Marco Martin notmart at gmail.com
Thu Apr 30 09:27:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123570/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
-------

When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much broken, since they can't find the structure instance.

in order to load packages one can subclass packageloader, but listing still doesn't work.
this makes possible for apps to insert new structure types without having to subclass.
an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in libplasma, because then any user of libplasma could replace the packageloader again, breaking it.


Diffs
-----

  src/kpackage/packageloader.h 4cc40e6 
  src/kpackage/packageloader.cpp 174f54b 

Diff: https://git.reviewboard.kde.org/r/123570/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150430/9625a1c8/attachment.html>


More information about the Plasma-devel mailing list