Review Request 123556: KPackage::findPackages with a filter callback

[Marco Martin]

> On April 29, 2015, 8:53 p.m., Alex Richardson wrote:
> > src/kpackage/packageloader.cpp, line 273
> > <https://git.reviewboard.kde.org/r/123556/diff/2/?file=364383#file364383line273>
> >
> >     This will crash if there is no filter.
> >     
> >     `if (!filter || filter(plugin))` should work.

done, thanks


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123556/#review79698
-----------------------------------------------------------


On April 29, 2015, 12:12 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123556/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Add a KPackage::findPackages function similar to KPluginLoader::findPlugins
> 
> 
> Diffs
> -----
> 
>   src/kpackage/packageloader.h 2761d98 
>   src/kpackage/packageloader.cpp 00defbd 
> 
> Diff: https://git.reviewboard.kde.org/r/123556/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150430/d052c04e/attachment-0001.html>