Review Request 123556: KPackage::findPackages with a filter callback
Alex Richardson
arichardson.kde at gmail.com
Wed Apr 29 20:53:02 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123556/#review79698
-----------------------------------------------------------
src/kpackage/packageloader.cpp (line 273)
<https://git.reviewboard.kde.org/r/123556/#comment54542>
This will crash if there is no filter.
`if (!filter || filter(plugin))` should work.
- Alex Richardson
On April 29, 2015, 1:12 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123556/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 1:12 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> Add a KPackage::findPackages function similar to KPluginLoader::findPlugins
>
>
> Diffs
> -----
>
> src/kpackage/packageloader.h 2761d98
> src/kpackage/packageloader.cpp 00defbd
>
> Diff: https://git.reviewboard.kde.org/r/123556/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150429/f7b9d5e9/attachment.html>
More information about the Plasma-devel
mailing list