Review Request 123502: Manually keep track of jobs sources

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123502/
-----------------------------------------------------------

(Updated April 27, 2015, 6:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Changes
-------

Submitted with commit bc5c47537f3bbb706b3fe7af66508f5ef2fadc6e by Kai Uwe Broulik to branch Plasma/5.3.


Bugs: 346673
    https://bugs.kde.org/show_bug.cgi?id=346673


Repository: plasma-workspace


Description
-------

DataSource sources is a QStringList property which means changes within cannot be tracked causing all the job delegates to be destroyed and re-created when sourcesChanged it emitted. This is pretty wasteful but also causes the delegate to lose their sate (eg. details expanded).


Diffs
-----

  applets/notifications/package/contents/ui/JobDelegate.qml 709b7fd 
  applets/notifications/package/contents/ui/Jobs.qml 6ecf366 

Diff: https://git.reviewboard.kde.org/r/123502/diff/


Testing
-------

Adding, removing and pausing jobs works as expected, when a job appears or disappears the other delegates keep their state.
The only slight imperfection is now that the indeterminate state of multiple jobs is no longer move in sync because the items are no longer created at the same time.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150427/52c82eb1/attachment.html>