Review Request 123502: Manually keep track of jobs sources

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123502/#review79554
-----------------------------------------------------------


Looks good

> indeterminate state of multiple jobs is no longer move in sync

If this is desired, the indet. state could be reset on all the jobs that are in that state (like set it again or set different state and right back to indeterminate) when new indet. job appears

- Martin Klapetek


On April 26, 2015, 7:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123502/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 7:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 346673
>     https://bugs.kde.org/show_bug.cgi?id=346673
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> DataSource sources is a QStringList property which means changes within cannot be tracked causing all the job delegates to be destroyed and re-created when sourcesChanged it emitted. This is pretty wasteful but also causes the delegate to lose their sate (eg. details expanded).
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/JobDelegate.qml 709b7fd 
>   applets/notifications/package/contents/ui/Jobs.qml 6ecf366 
> 
> Diff: https://git.reviewboard.kde.org/r/123502/diff/
> 
> 
> Testing
> -------
> 
> Adding, removing and pausing jobs works as expected, when a job appears or disappears the other delegates keep their state.
> The only slight imperfection is now that the indeterminate state of multiple jobs is no longer move in sync because the items are no longer created at the same time.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150427/e4e6a94c/attachment.html>