Review Request 123530: Improve interactivity for the user icon and search field in kickoff

[Lukáš Tinkl]

> On Dub. 27, 2015, 4:48 odp., Kai Uwe Broulik wrote:
> > applets/kickoff/package/contents/ui/Header.qml, line 95
> > <https://git.reviewboard.kde.org/r/123530/diff/1/?file=363749#file363749line95>
> >
> >     Does this need to be duplicated? I suppose the hit area for both items should be pretty similar so you could place a single MouseArea one level up.

I fail to see how could I refactor this one level up... the MouseArea has to be inside the Image/IconItem


> On Dub. 27, 2015, 4:48 odp., Kai Uwe Broulik wrote:
> > applets/kickoff/package/contents/ui/Header.qml, line 166
> > <https://git.reviewboard.kde.org/r/123530/diff/1/?file=363749#file363749line166>
> >
> >     If you put the TextField outside the MouseArea, you could probably just do
> >     
> >     > visible: header.state === "hint"
> >     
> >     and safe the cursorShape and enabled dance

same here


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123530/#review79575
-----------------------------------------------------------


On Dub. 27, 2015, 4:31 odp., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123530/
> -----------------------------------------------------------
> 
> (Updated Dub. 27, 2015, 4:31 odp.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 
>   applets/kickoff/package/contents/ui/Header.qml dfabbe5 
> 
> Diff: https://git.reviewboard.kde.org/r/123530/diff/
> 
> 
> Testing
> -------
> 
> Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup.
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150427/5b978d1f/attachment.html>