Review Request 123530: Improve interactivity for the user icon and search field in kickoff

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123530/#review79575
-----------------------------------------------------------


Good idea!

A couple of nitpicky suggestions below :)


applets/kickoff/package/contents/ui/Header.qml (line 38)
<https://git.reviewboard.kde.org/r/123530/#comment54367>

    !==
    
    If you change it below, change it here too ;)



applets/kickoff/package/contents/ui/Header.qml (line 95)
<https://git.reviewboard.kde.org/r/123530/#comment54368>

    Does this need to be duplicated? I suppose the hit area for both items should be pretty similar so you could place a single MouseArea one level up.



applets/kickoff/package/contents/ui/Header.qml (line 166)
<https://git.reviewboard.kde.org/r/123530/#comment54369>

    If you put the TextField outside the MouseArea, you could probably just do
    
    > visible: header.state === "hint"
    
    and safe the cursorShape and enabled dance


- Kai Uwe Broulik


On April 27, 2015, 2:31 nachm., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123530/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 2:31 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 
>   applets/kickoff/package/contents/ui/Header.qml dfabbe5 
> 
> Diff: https://git.reviewboard.kde.org/r/123530/diff/
> 
> 
> Testing
> -------
> 
> Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup.
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150427/e631d6d5/attachment-0001.html>