Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

[Antonis Tsiapaliokas]

> On April 21, 2015, 9:47 p.m., David Edmundson wrote:
> > lookandfeel/contents/components/InfoPane.qml, line 47
> > <https://git.reviewboard.kde.org/r/123459/diff/1/?file=362312#file362312line47>
> >
> >     there's a visible here.
> >     
> >     If your two lines are needed, this isn't.
> >     
> >     Or this should be changed to the battery.hasBattery instead.

Yes, we have to use this "visible".
My two lines are a bit of overkill.


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123459/#review79311
-----------------------------------------------------------


On April 24, 2015, 6:22 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123459/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346441
>     https://bugs.kde.org/show_bug.cgi?id=346441
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery).
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/components/InfoPane.qml 18739ad 
> 
> Diff: https://git.reviewboard.kde.org/r/123459/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> no battery after
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png
> no battery before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150424/9acfe28d/attachment-0001.html>